Go #1250 remove multiple candidates support #1307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2024 16:31
…t and GenerateResponse with the new Model types
Hmm, I'm guessing it failed? What did it say? We should look into this. Technically both the The rest LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported new types and omit deprecated ones
Removed all references to Candidates, and replace GenerateRequest and GenerateResponse with the new Model types
I chose to skip "TestReflectionAPI/test_app/api/runAction" test in TestReflectionAPI, since the yaml seems to be shared with JS?
Checklist (if applicable):